Re: [PR] SOLR-6962: bin/solr stop -a should complain about missing parameter [solr]

2024-09-10 Thread via GitHub
rahulgoswami commented on PR #2671: URL: https://github.com/apache/solr/pull/2671#issuecomment-2342548913 I tried main as well as the tag for the latest 9.x release "releases/solr/9.7.0" on Windows. I am observing the same behavior in both cases where "solr stop -a" doesn't hang and gives a

Re: [PR] SOLR-16976: Remove log4j-jul jar and use slf4j bridge for JUL [solr]

2024-09-10 Thread via GitHub
szhou1998 commented on PR #2703: URL: https://github.com/apache/solr/pull/2703#issuecomment-2342084894 Ah my mistake, Solr starts even though the exception is logged. Added a refute_output for the exception. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] SOLR-16976: Remove log4j-jul jar and use slf4j bridge for JUL [solr]

2024-09-10 Thread via GitHub
epugh commented on PR #2703: URL: https://github.com/apache/solr/pull/2703#issuecomment-2342050120 Humm... I ran the "Solr Script Tests" expecting it to fail...I can run it locally tomorrow and see what I see! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] SOLR-16976: Remove log4j-jul jar and use slf4j bridge for JUL [solr]

2024-09-10 Thread via GitHub
szhou1998 commented on PR #2703: URL: https://github.com/apache/solr/pull/2703#issuecomment-2341973941 > I don't have much knowledge in how logging works. One thing that would help, would you mind creating a BATS style test that demonstrates the bug and the fix? I believe you could write a

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-10 Thread via GitHub
dsmiley commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1752562414 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedCollec

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-10 Thread via GitHub
dsmiley commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1752552453 ## solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Commented] (SOLR-17382) CLI: Deprecate addlopts in RunExampleTool.java

2024-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880717#comment-17880717 ] ASF subversion and git services commented on SOLR-17382: Commit 5

[jira] [Commented] (SOLR-11318) Add tests for AssertTool

2024-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880716#comment-17880716 ] ASF subversion and git services commented on SOLR-11318: Commit 1

[PR] Add filter query tracing [solr]

2024-09-10 Thread via GitHub
risdenk opened a new pull request, #2704: URL: https://github.com/apache/solr/pull/2704 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution Pl

Re: [PR] Add scripts to fetch+prepare solr-community data [solr-sandbox]

2024-09-10 Thread via GitHub
gerlowskija commented on PR #111: URL: https://github.com/apache/solr-sandbox/pull/111#issuecomment-2341304339 Thanks for the review @epugh. I addressed most of your comments - defaulting to a local 'output' dir for the scripts to use was a particularly nice improvement 👍 Let me kn

[jira] [Commented] (SOLR-7122) bin scripts don't have executable permissions in src releases

2024-09-10 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880664#comment-17880664 ] Eric Pugh commented on SOLR-7122: - I ran "gw dev" and then checked solr/packaging/build/so

[jira] [Commented] (SOLR-17446) The Jetty/Solr process should stop if CoreContainer doesn't initialize

2024-09-10 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880654#comment-17880654 ] Jan Høydahl commented on SOLR-17446: I think this is due to the fact that Jetty servl

[jira] [Commented] (SOLR-17439) jattach does not work with Solr in Docker

2024-09-10 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880652#comment-17880652 ] Roland Müller commented on SOLR-17439: -- Thanks for the response! Maybe it is possib

[jira] [Updated] (SOLR-17445) update base image to eclipse-temurin:21-jre-noble

2024-09-10 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17445: --- Description: Docker base image is configured in the templates in main solr repo, and it would be natu

[jira] [Resolved] (SOLR-17439) jattach does not work with Solr in Docker

2024-09-10 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17439. Assignee: Jan Høydahl Resolution: Not A Problem It works, you just have to find the PID of th

[jira] [Commented] (SOLR-7122) bin scripts don't have executable permissions in src releases

2024-09-10 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880615#comment-17880615 ] Eric Pugh commented on SOLR-7122: - I checked online, and it appears that the exec bit is N