epugh commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2232513816
One more thought which is that sometimes I find it easier to write a bats
test instead of Java... post.bats is used to test out the cli against a live
solr...
--
This is an automated
solrbot commented on PR #2169:
URL: https://github.com/apache/solr/pull/2169#issuecomment-2232104098
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
solrbot commented on PR #1821:
URL: https://github.com/apache/solr/pull/1821#issuecomment-2232103487
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
TravisFarrellMCC commented on issue #501:
URL: https://github.com/apache/solr-operator/issues/501#issuecomment-2231911313
@HoustonPutman @vipul-06 Any tips on how to stop the metrics pod from
crashing? We upgraded Solr Operator to 0.8.1 as there was a fix listed for the
Promethius
janhoy merged PR #2413:
URL: https://github.com/apache/solr/pull/2413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kbarnesMCC commented on issue #501:
URL: https://github.com/apache/solr-operator/issues/501#issuecomment-2231893266
@vipul-06 did you ever get a resolution to this? I'm experiencing the exact
same issue in your latest update...everything seems to be working but
ultimately a
janhoy commented on PR #2129:
URL: https://github.com/apache/solr/pull/2129#issuecomment-2231890330
@risdenk Do we need to do manual work as part of this upgrade, such as
enabling new inspections?
--
This is an automated message from the Apache Git Service.
To respond to the message,
janhoy merged PR #2406:
URL: https://github.com/apache/solr/pull/2406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #2182:
URL: https://github.com/apache/solr/pull/2182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #2468:
URL: https://github.com/apache/solr/pull/2468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #2560:
URL: https://github.com/apache/solr/pull/2560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #2562:
URL: https://github.com/apache/solr/pull/2562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on PR #2553:
URL: https://github.com/apache/solr/pull/2553#issuecomment-2231873442
Thanks for bringin up this issue @cclauss, even if your pr was not used. I
now got the renovate bot working, after tweaking an access token with
`workflow` permission. See #2562 for an
solrbot opened a new pull request, #2565:
URL: https://github.com/apache/solr/pull/2565
This PR contains the following updates:
| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
|
solrbot opened a new pull request, #2564:
URL: https://github.com/apache/solr/pull/2564
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/upload-artifact](https://togithub.com/actions/upload-artifact) |
action | major |
solrbot opened a new pull request, #2563:
URL: https://github.com/apache/solr/pull/2563
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/setup-java](https://togithub.com/actions/setup-java) | action |
major | `v2` -> `v4`
solrbot opened a new pull request, #2562:
URL: https://github.com/apache/solr/pull/2562
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout) | action | major
| `v2` -> `v4` |
solrbot opened a new pull request, #2561:
URL: https://github.com/apache/solr/pull/2561
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/cache](https://togithub.com/actions/cache) | action | major |
`v2` -> `v4` |
cclauss closed pull request #2553: Keep GitHub Actions up to date with GitHub's
Dependabot
URL: https://github.com/apache/solr/pull/2553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2231780886
I filed SOLR-17371 for forward-porting.
Also synced PR branch with branch_9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
solrbot opened a new pull request, #2560:
URL: https://github.com/apache/solr/pull/2560
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[com.fasterxml.jackson:jackson-bom](https://togithub.com/FasterXML/jackson-bom)
|
solrbot commented on PR #2047:
URL: https://github.com/apache/solr/pull/2047#issuecomment-2231740761
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231681249
> > thanks for the addition of the tests.. I will inline some comments
one thing, did you run `gradlew tidy`? that does some code formatting.
>
> I did not 臘♂️. I had a blast
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679963315
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679962349
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
janhoy merged PR #2559:
URL: https://github.com/apache/solr/pull/2559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231661162
> Looks like some great progress. A couple of questions! When I add it to
`CHANGES.txt`, how would you like to be credited?
Bostoi
Thank you
--
This is an automated
janhoy commented on PR #2553:
URL: https://github.com/apache/solr/pull/2553#issuecomment-2231647541
I have made an attempt to enable the `github-actions` manager for renovate
in #2559. Let's see if it works..
--
This is an automated message from the Apache Git Service.
To respond to the
bogdanstoik commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231646527
> thanks for the addition of the tests.. I will inline some comments one
thing, did you run `gradlew tidy`? that does some code formatting.
I did not 臘♂️.
I had a blast
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679930353
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679929573
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679926338
##
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##
@@ -147,6 +147,43 @@ public void testRunWithCollectionParam() throws Exception {
bogdanstoik commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679924535
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -311,6 +312,8 @@ public void runImpl(CommandLine cli) throws Exception {
args = cli.getArgs();
HoustonPutman merged PR #2541:
URL: https://github.com/apache/solr/pull/2541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bruno-roustant commented on PR #2548:
URL: https://github.com/apache/solr/pull/2548#issuecomment-2231204655
Could you rerun the benchmark 'After'? The error range is high on the first
line.
Does the benchmark outputs if there is more GC? I'm thinking of the new
transient small lock
epugh merged PR #2530:
URL: https://github.com/apache/solr/pull/2530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on code in PR #2557:
URL: https://github.com/apache/solr/pull/2557#discussion_r1679567571
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -311,6 +312,8 @@ public void runImpl(CommandLine cli) throws Exception {
args = cli.getArgs();
+
epugh commented on PR #2557:
URL: https://github.com/apache/solr/pull/2557#issuecomment-2231124432
thanks for the addition of the tests.. I will inline some comments
one thing, did you run `gradlew tidy`? that does some code formatting.
--
This is an automated message from the
dsmiley commented on PR #2548:
URL: https://github.com/apache/solr/pull/2548#issuecomment-2231017918
Before
```
Benchmark (nodeCount) (numReplicas) (numShards)
(preGenerate) (useSmallDocs) Mode Cnt Score Error Units
CloudIndexing.indexDoc
lizbiella commented on PR #114:
URL: https://github.com/apache/solr-site/pull/114#issuecomment-2230870065
Thanks @janhoy ! I will add "(external link)" for the next blog post. Feel
free to comment in the next pull request if you think it is better to change it.
--
This is an automated
danielsason112 opened a new issue, #109:
URL: https://github.com/apache/solr-sandbox/issues/109
Hi, tried using the encryption plugin.
steps to reproduce the issue:
- Create a new collection with the encryption config
- Invoke the /admin/encrypt API
- Insert a new
bogdanstoik opened a new pull request, #2557:
URL: https://github.com/apache/solr/pull/2557
https://issues.apache.org/jira/browse/SOLR-17367
# Description
Adding support for -params option in org.apache.solr.cli.PostTool
# Solution
I modified the
bogdanstoik closed pull request #2556: SOLR-17367: org.apache.solr.cli.PostTool
is ignoring -params option
URL: https://github.com/apache/solr/pull/2556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
janhoy opened a new pull request, #115:
URL: https://github.com/apache/solr-site/pull/115
I noticed when testing the latest PR #114 locally that the post, dated July
15th, sorted above the existing July 1st post. It is since the template
explicitly sorts by the english surface form of the
bogdanstoik opened a new pull request, #2556:
URL: https://github.com/apache/solr/pull/2556
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
dsmiley merged PR #2304:
URL: https://github.com/apache/solr/pull/2304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman commented on PR #2541:
URL: https://github.com/apache/solr/pull/2541#issuecomment-2229188195
Ok I've addressed your comments, thanks!
I've added a line for the windows thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please
HoustonPutman commented on code in PR #2541:
URL: https://github.com/apache/solr/pull/2541#discussion_r1678270283
##
solr/modules/cross-dc/src/test-files/configs/cloud-minimal.zip:
##
Review Comment:
Ok, I've added generating it to the gradle build, so it doesn't fall
epugh commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2228845624
Good thoughts here @janhoy... I will leave this open for another day or
so, and then look to commit it. I will put out an appeal to the dev mailing
list when 9.7 release process starts
epugh merged PR #2554:
URL: https://github.com/apache/solr/pull/2554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
QFREEE commented on code in PR #2554:
URL: https://github.com/apache/solr/pull/2554#discussion_r1678055749
##
solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc:
##
@@ -1614,9 +1614,10 @@ Provided as a query parameter for v1 requests, and as a
path
epugh commented on PR #2555:
URL: https://github.com/apache/solr/pull/2555#issuecomment-2228835601
Thanks for this nice fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
epugh merged PR #2555:
URL: https://github.com/apache/solr/pull/2555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
QFREEE opened a new pull request, #2555:
URL: https://github.com/apache/solr/pull/2555
missing a +
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to
cclauss commented on PR #2553:
URL: https://github.com/apache/solr/pull/2553#issuecomment-2228443944
I read through that but could not see how those instructions aligned with
`.github/renovate.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message,
janhoy commented on PR #113:
URL: https://github.com/apache/solr-site/pull/113#issuecomment-2228265269
Yep, action maintainers in infra has since made a change to not have a
default, and since we use a non-versioned action (`@main`) it affects us.
--
This is an automated message from the
janhoy commented on PR #2553:
URL: https://github.com/apache/solr/pull/2553#issuecomment-2228255250
Could the same be achieved using our existing Renovate bot, instead of
introducing a different bot?
https://docs.renovatebot.com/modules/manager/github-actions/
--
This is an automated
lizbiella opened a new pull request, #114:
URL: https://github.com/apache/solr-site/pull/114
I added a new blog post about the Apache Solr Performance test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2228245666
It’s the best I could do with my available time. I have NOT done a thorough
review of all options in all tools, just fixed the ones causing test failures.
The windows script lacks
epugh commented on code in PR #2554:
URL: https://github.com/apache/solr/pull/2554#discussion_r1677613235
##
solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc:
##
@@ -1614,9 +1614,10 @@ Provided as a query parameter for v1 requests, and as a
path
epugh merged PR #2550:
URL: https://github.com/apache/solr/pull/2550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
madrob commented on PR #113:
URL: https://github.com/apache/solr-site/pull/113#issuecomment-2227652397
I'm confused why this needs an explicit configuration since in
https://github.com/apache/infrastructure-actions/pull/63 it looks like you gave
it a default value. Am I missing something?
janhoy merged PR #111:
URL: https://github.com/apache/solr-site/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #112:
URL: https://github.com/apache/solr-site/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #113:
URL: https://github.com/apache/solr-site/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy opened a new pull request, #113:
URL: https://github.com/apache/solr-site/pull/113
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
malliaridis commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676978086
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
I would resolve this for now without adding to the file a license header
malliaridis commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676978086
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
I would resolve this for now without adding to the file a license header
geffchang commented on PR #210:
URL: https://github.com/apache/solr/pull/210#issuecomment-2226851356
@epugh Unfortunately, I'm not familiar with this and haven't tried the code
either.
@rainerjung Any chance you can create a unit test?
--
This is an automated message from the
epugh commented on PR #210:
URL: https://github.com/apache/solr/pull/210#issuecomment-2226779616
@geffchang going back up in the comments, it looks like this needs a unit
test. At a minimum we need to have the set of steps for manually reproducing
the issue... for me to feel
github-actions[bot] commented on PR #210:
URL: https://github.com/apache/solr/pull/210#issuecomment-2226549606
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity or converting it to draft will remove the stale label. To attract
more reviewers, please
dsmiley commented on PR #2304:
URL: https://github.com/apache/solr/pull/2304#issuecomment-2226380179
I handled CHANGES.txt myself. I'll merge this sometime this weekend.
Looking forward to seeing this one done!
--
This is an automated message from the Apache Git Service.
To respond to
QFREEE opened a new pull request, #2554:
URL: https://github.com/apache/solr/pull/2554
Based on
https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cloud/api/collections/BackupCmd.java#L201
and
gerlowskija commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676155586
##
solr/solr-ref-guide/ui-src/css/tabs.css:
##
@@ -0,0 +1,103 @@
+.tabs {
Review Comment:
Makes sense to me. Looks like you already created SOLR-17365 to cover
cpoerschke commented on PR #2546:
URL: https://github.com/apache/solr/pull/2546#issuecomment-2225112906
> ... Curious why you chose the `artifact` build over the `check` build
though.
Errm, not a choice as such, just did the same as what the Lucene badge does.
I guess technically we
markrmiller commented on PR #2541:
URL: https://github.com/apache/solr/pull/2541#issuecomment-2224701112
So I responded to those questions, but since they no longer lined up with
the existing code, I didn't know if they were still relevant, so I didn't spend
a lot of time investigating.
markrmiller commented on code in PR #2541:
URL: https://github.com/apache/solr/pull/2541#discussion_r1675330963
##
solr/cross-dc-manager/src/test/org/apache/solr/crossdc/manager/SimpleSolrIntegrationTest.java:
##
@@ -46,21 +45,21 @@ public static void ensureWorkingMockito() {
markrmiller commented on code in PR #2541:
URL: https://github.com/apache/solr/pull/2541#discussion_r1675329967
##
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/messageprocessor/SolrMessageProcessor.java:
##
@@ -29,345 +33,369 @@
import
markrmiller commented on code in PR #2541:
URL: https://github.com/apache/solr/pull/2541#discussion_r1675329123
##
solr/modules/cross-dc/src/test-files/configs/cloud-minimal.zip:
##
Review Comment:
I guess it depends on what you mean by "need". At the most basic level, I
markrmiller commented on PR #2541:
URL: https://github.com/apache/solr/pull/2541#issuecomment-2224680147
So I tried this out on Windows today, and I still get the same issue. Maybe
we can conditionally disable the test policy for this module for Windows?
> It appears as if your
cclauss opened a new pull request, #2553:
URL: https://github.com/apache/solr/pull/2553
Automate the creation of pull requests like
* #2552
Fixes software supply chain safety warnings like at the bottom right of
https://github.com/apache/solr/actions/runs/9893380263
*
HoustonPutman merged PR #2533:
URL: https://github.com/apache/solr/pull/2533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman merged PR #2552:
URL: https://github.com/apache/solr/pull/2552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2223487564
It won't but that's ok, there's a jenkins job to do it manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
epugh commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2223108355
@janhoy, just looking again at this one, thanks for all the efforts
This looks like it's ready to commit? However before I click "Squash and
merge", I wanted to confirm with you!!
epugh commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2223104446
Okay, I want to commit this. I *believe* that when we cut the new ref guide
for 9.7, that the changes to the ui bundle will then happen IIUC
--
This is an automated message from the
serba commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1673451696
##
solr/core/src/test-files/solr/collection1/conf/bad-schema-unsupported-docValues.xml:
##
Review Comment:
I think this test is not testing binary doc values per say,
serba commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1673447557
##
solr/core/src/java/org/apache/solr/schema/BinaryField.java:
##
@@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field,
Object val) {
len =
cclauss opened a new pull request, #2552:
URL: https://github.com/apache/solr/pull/2552
* https://github.com/actions/checkout/releases
* https://github.com/actions/setup-java/releases
* https://github.com/actions/cache/releases
https://issues.apache.org/jira/browse/SOLR-X
epugh commented on PR #2539:
URL: https://github.com/apache/solr/pull/2539#issuecomment-2221062297
> > LGTM. Is the URIBuilder something that we should be using in more places?
>
>
>
> I certainly think so
How do we get these tasks actually tracked and moved forward?
HoustonPutman merged PR #2539:
URL: https://github.com/apache/solr/pull/2539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman commented on PR #2539:
URL: https://github.com/apache/solr/pull/2539#issuecomment-2220953778
> LGTM. Is the URIBuilder something that we should be using in more places?
I certainly think so
--
This is an automated message from the Apache Git Service.
To respond to the
HoustonPutman commented on code in PR #2542:
URL: https://github.com/apache/solr/pull/2542#discussion_r1672610162
##
solr/docker/templates/Dockerfile.body.template:
##
@@ -72,6 +72,8 @@ RUN set -ex; \
RUN set -ex; \
apt-get update; \
apt-get -y
HoustonPutman commented on PR #2546:
URL: https://github.com/apache/solr/pull/2546#issuecomment-2220949563
Thank you! Curious why you chose the `artifact` build over the `check` build
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
HoustonPutman commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2220946846
> It sounds like this pr is good to go, hopefully @HoustonPutman will create
the jira for adding missing licenses!
I just went through the long history of the Antora work and
HoustonPutman commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2220924389
This should absolutely be credited in the changelog!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mkhludnev commented on code in PR #2536:
URL: https://github.com/apache/solr/pull/2536#discussion_r1670638010
##
solr/core/src/java/org/apache/solr/schema/BinaryField.java:
##
@@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field,
Object val) {
len =
markrmiller commented on PR #2541:
URL: https://github.com/apache/solr/pull/2541#issuecomment-2219344405
I didn't get to this today, but will respond and test out on windows
tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
malliaridis commented on PR #2550:
URL: https://github.com/apache/solr/pull/2550#issuecomment-2219241785
> We don't normally credit ref guide changes but maybe should with this one
since it's improving the tooling. @malliaridis how do you want to be credited?
Your kind offer @epugh
github-actions[bot] commented on PR #939:
URL: https://github.com/apache/solr/pull/939#issuecomment-2219068808
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity or converting it to draft will remove the stale label. To attract
more reviewers, please
1 - 100 of 10039 matches
Mail list logo
