Re: [PR] Upgrade Log4j to `2.25.1` [solr]

2025-09-03 Thread via GitHub
ppkarwasz commented on code in PR #3603: URL: https://github.com/apache/solr/pull/3603#discussion_r2319952721 ## solr/licenses/org.osgi.annotation.bundle-LICENSE-ASL.txt: ## @@ -0,0 +1,202 @@ + + Apache License + Version

Re: [PR] SOLR-17868: Introduce a single page in Ref Guide to list all system properties [solr]

2025-09-03 Thread via GitHub
epugh commented on PR #3613: URL: https://github.com/apache/solr/pull/3613#issuecomment-3250366821 Okay, I think I'm done on this. I'm hoping this page grows over time to gather ALL the various properties that can be set. May find we have to restructure it if it gets too long! -- This

Re: [PR] SOLR-17891: Reorganize the DeprecatedSystemPropertyMappings file [solr]

2025-09-03 Thread via GitHub
epugh commented on PR #3608: URL: https://github.com/apache/solr/pull/3608#issuecomment-3250325077 > Is there a bats (or other) test for a legacy property? There is; in the `test_start_solr.bats` file that verifies the warning shows up in the logs. -- This is an automated message

Re: [PR] SOLR-17875: Redo of Rationalize bootstrap_conf, bootstrap_confdir, and -Dcollection.configName in start up scripts [solr]

2025-09-03 Thread via GitHub
epugh merged PR #3604: URL: https://github.com/apache/solr/pull/3604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17780: Add support for scalar quantized dense vectors [solr]

2025-09-03 Thread via GitHub
liangkaiwen commented on PR #3385: URL: https://github.com/apache/solr/pull/3385#issuecomment-3250303573 Huh, I thought it had passed after I committed my last changes but I guess not. No problem, I will handle it -- This is an automated message from the Apache Git Service. To respond to

[PR] SOLR-17868: Introduce a single page in Ref Guide to list all system properties [solr]

2025-09-03 Thread via GitHub
epugh opened a new pull request, #3613: URL: https://github.com/apache/solr/pull/3613 https://issues.apache.org/jira/browse/SOLR-17868 # Description Add a single Ref Guide page to have all system properties. https://github.com/user-attachments/assets/bae094cb-a959-438

Re: [PR] SOLR-17875: Redo of Rationalize bootstrap_conf, bootstrap_confdir, and -Dcollection.configName in start up scripts [solr]

2025-09-03 Thread via GitHub
dsmiley commented on code in PR #3604: URL: https://github.com/apache/solr/pull/3604#discussion_r2319728252 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -47,7 +47,8 @@ To learn about the updated options in each CLI tool, use the `--hel

Re: [PR] Upgrade Log4j to `2.25.1` [solr]

2025-09-03 Thread via GitHub
risdenk commented on code in PR #3603: URL: https://github.com/apache/solr/pull/3603#discussion_r2319657591 ## solr/modules/extraction/build.gradle: ## @@ -19,6 +19,13 @@ apply plugin: 'java-library' description = 'Solr Integration with Tika for extracting content from binary

Re: [PR] Upgrade Log4j to `2.25.1` [solr]

2025-09-03 Thread via GitHub
risdenk commented on PR #3603: URL: https://github.com/apache/solr/pull/3603#issuecomment-3250084988 FYI https://github.com/apache/solr/pull/2895 was another attempt prior to this. There was a comment about licenses needing to be reviewed as well. https://github.com/apache/solr/pull/2895?ne

Re: [PR] upgrade-log4j2-2.24.2 [solr]

2025-09-03 Thread via GitHub
risdenk closed pull request #2895: upgrade-log4j2-2.24.2 URL: https://github.com/apache/solr/pull/2895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

Re: [PR] upgrade-log4j2-2.24.2 [solr]

2025-09-03 Thread via GitHub
risdenk commented on PR #2895: URL: https://github.com/apache/solr/pull/2895#issuecomment-3250078461 Closing in favor of https://github.com/apache/solr/pull/3603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Update netty to v4.2.5.Final [solr]

2025-09-03 Thread via GitHub
solrbot opened a new pull request, #3612: URL: https://github.com/apache/solr/pull/3612 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.netty:netty-transport-native-epoll](https://netty.io/) ([source](https://redirect.github.c

Re: [PR] Update eclipse.jetty [solr]

2025-09-03 Thread via GitHub
iamsanjay commented on PR #3071: URL: https://github.com/apache/solr/pull/3071#issuecomment-3249663192 This seems to be a big change in terms of things it's affecting -- still few test cases are failing. Starting to think if going to 12.0.25 is better option in compare to 12.1.0 jetty.

Re: [PR] SOLR-17780: Add support for scalar quantized dense vectors [solr]

2025-09-03 Thread via GitHub
alessandrobenedetti commented on PR #3385: URL: https://github.com/apache/solr/pull/3385#issuecomment-3249550133 I fixed the tidy problem, but the tests (the ones expected to throw exceptions) are still failing. I gave it a very quick try, with debug, but it doesn't look obvious to me, a

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2319184435 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2319184435 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2319184435 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r231912 ## solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java: ## @@ -82,6 +82,14 @@ public void prepare(ResponseBuilder rb) throws IOException {

Re: [PR] SOLR-17780: Add support for scalar quantized dense vectors [solr]

2025-09-03 Thread via GitHub
alessandrobenedetti commented on PR #3385: URL: https://github.com/apache/solr/pull/3385#issuecomment-3249436008 Checks and tests are still failing @liangkaiwen , I'll give it a try now, If I fix them in 1 hour I'll merge, if not I'll ask you to give a double check, keep you posted! -- T

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2319049507 ## solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java: ## @@ -82,6 +82,14 @@ public void prepare(ResponseBuilder rb) throws IOException { r

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318978519 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,572 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-17875: Redo of Rationalize bootstrap_conf, bootstrap_confdir, and -Dcollection.configName in start up scripts [solr]

2025-09-03 Thread via GitHub
epugh commented on code in PR #3604: URL: https://github.com/apache/solr/pull/3604#discussion_r2318956151 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -702,13 +700,6 @@ public static void createCollectionZkNode( }

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
dsmiley commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318929806 ## solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java: ## @@ -82,6 +82,14 @@ public void prepare(ResponseBuilder rb) throws IOException { rb.s

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
dsmiley commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318914312 ## solr/core/src/test/org/apache/solr/search/combine/ReciprocalRankFusionTest.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
dsmiley commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318895113 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to the Apac

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r231403 ## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ## @@ -905,7 +906,84 @@ protected boolean addFL(StringBuilder fl, String field, boolean ad

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2317761872 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,590 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318852609 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318785260 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to the A

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318605879 ## solr/core/src/test/org/apache/solr/search/combine/ReciprocalRankFusionTest.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318603576 ## solr/core/src/java/org/apache/solr/search/combine/ReciprocalRankFusion.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2318601809 ## solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software Foun

[PR] Bump apache-kafka from 3.9.0 to 4.1.0 [solr]

2025-09-03 Thread via GitHub
dependabot[bot] opened a new pull request, #3611: URL: https://github.com/apache/solr/pull/3611 Bumps `apache-kafka` from 3.9.0 to 4.1.0. Updates `org.apache.kafka:kafka-clients` from 3.9.0 to 4.1.0 Updates `org.apache.kafka:kafka_2.13` from 3.9.0 to 4.1.0 Updates `org.apache

[PR] Remove some dead code from distributed updater [solr]

2025-09-03 Thread via GitHub
psalagnac opened a new pull request, #3610: URL: https://github.com/apache/solr/pull/3610 Simple code cleanup. No functional change @murblanc is the initial author of most the this change (I'm not adding an entry in change log, so just mentioning this here). -- This is an automated

Re: [PR] SOLR-17780: Add support for scalar quantized dense vectors [solr]

2025-09-03 Thread via GitHub
dsmiley commented on PR #3385: URL: https://github.com/apache/solr/pull/3385#issuecomment-3243516726 I don't recall Crave being confused by a merge from "main". I do recall once in a while (rare-ish), GitHub PR would show changes from the merge that it shouldn't. -- This is an automat

Re: [PR] Adding dependency graph submission workflow [solr]

2025-09-03 Thread via GitHub
iamsanjay merged PR #3502: URL: https://github.com/apache/solr/pull/3502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] Update eclipse.jetty [solr]

2025-09-03 Thread via GitHub
solrbot commented on PR #3071: URL: https://github.com/apache/solr/pull/3071#issuecomment-3248292627 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

Re: [PR] Update eclipse.jetty [solr]

2025-09-03 Thread via GitHub
iamsanjay commented on PR #3071: URL: https://github.com/apache/solr/pull/3071#issuecomment-3248209296 Reproduce with: ./gradlew :solr:solrj:test --tests "org.apache.solr.client.solrj.impl.BasicHttpSolrClientTest.testQuery" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:Ac

Re: [PR] Update eclipse.jetty [solr]

2025-09-03 Thread via GitHub
iamsanjay commented on code in PR #3071: URL: https://github.com/apache/solr/pull/3071#discussion_r2318177399 ## solr/core/build.gradle: ## @@ -119,7 +119,6 @@ dependencies { implementation libs.eclipse.jetty.client implementation libs.eclipse.jetty.http Review Comment:

Re: [PR] Update eclipse.jetty [solr]

2025-09-03 Thread via GitHub
iamsanjay commented on code in PR #3071: URL: https://github.com/apache/solr/pull/3071#discussion_r2318166306 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientCompatibilityTest.java: ## @@ -36,11 +36,13 @@ public class Http2SolrClientCompatibilityTest exte

Re: [PR] Update eclipse.jetty [solr]

2025-09-03 Thread via GitHub
Copilot commented on code in PR #3071: URL: https://github.com/apache/solr/pull/3071#discussion_r2318149096 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientCompatibilityTest.java: ## @@ -36,11 +36,13 @@ public class Http2SolrClientCompatibilityTest extend

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2315324958 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,113 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] Update apache.log4j to v2.25.1 [solr]

2025-09-03 Thread via GitHub
ppkarwasz commented on PR #3079: URL: https://github.com/apache/solr/pull/3079#issuecomment-3245269829 ``` * What went wrong: Execution failed for task ':solr:core:analyzeClassesDependencies'. > Dependency analysis found issues. unusedDeclaredArtifacts - biz.aQute.bnd:biz

Re: [PR] Migrate SolrIndexSearcher metrics to OTEL [solr]

2025-09-03 Thread via GitHub
mlbiscoc commented on code in PR #3482: URL: https://github.com/apache/solr/pull/3482#discussion_r2316508963 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -2589,95 +2602,145 @@ public SolrMetricsContext getSolrMetricsContext() { return solrMetri

Re: [PR] Update dependency com.carrotsearch.randomizedtesting:randomizedtesting-runner to v2.8.3 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3062: URL: https://github.com/apache/solr/pull/3062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17864: Migrate properties to modern Solr equivalents [solr]

2025-09-03 Thread via GitHub
epugh merged PR #3506: URL: https://github.com/apache/solr/pull/3506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update slf4j to v2.0.17 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3219: URL: https://github.com/apache/solr/pull/3219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency com.adobe.testing:s3mock-junit4 to v4 (branch_9x) [solr]

2025-09-03 Thread via GitHub
janhoy closed pull request #3594: Update dependency com.adobe.testing:s3mock-junit4 to v4 (branch_9x) URL: https://github.com/apache/solr/pull/3594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Update dependency commons-codec:commons-codec to v1.19.0 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3063: URL: https://github.com/apache/solr/pull/3063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency joda-time:joda-time to v2.14.0 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3097: URL: https://github.com/apache/solr/pull/3097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17877: Introduce cluster property overseerEnabled, replacing dual booleans [solr]

2025-09-03 Thread via GitHub
dsmiley commented on PR #3524: URL: https://github.com/apache/solr/pull/3524#issuecomment-3245381342 Thanks for the review! I addressed the comments, including deciding to incorporate upgrade notes into this PR instead of deferring to another. -- This is an automated message from the Apa

Re: [PR] Update dependency de.undercouch.download to v5.6.0 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3096: URL: https://github.com/apache/solr/pull/3096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17884: SolrJ, minimize org.apache.http usage [solr]

2025-09-03 Thread via GitHub
dsmiley commented on code in PR #3602: URL: https://github.com/apache/solr/pull/3602#discussion_r2314815742 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java: ## @@ -73,42 +78,19 @@ * @deprecated Used to configure the Apache HTTP client. Please use t

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2317761758 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,112 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] Update dependency org.semver4j:semver4j to v5.8.0 (branch_9x) [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3558: URL: https://github.com/apache/solr/pull/3558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Remove unused method SolrCloudManager.request() [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3599: URL: https://github.com/apache/solr/pull/3599#discussion_r2314384772 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/cloud/DelegatingCloudManager.java: ## @@ -27,10 +25,11 @@ /** Base class for overriding some behavior of

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2315036487 ## solr/solr-ref-guide/modules/query-guide/pages/json-combined-query-dsl.adoc: ## @@ -0,0 +1,113 @@ += JSON Combined Query DSL +:tabs-sync-option: +// Licensed to th

Re: [PR] Update dependency com.google.code.gson:gson to v2.13.1 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3143: URL: https://github.com/apache/solr/pull/3143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update apache.zookeeper to v3.9.4 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3523: URL: https://github.com/apache/solr/pull/3523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency com.squareup.okhttp3:okhttp to v5 [solr]

2025-09-03 Thread via GitHub
solrbot commented on PR #3473: URL: https://github.com/apache/solr/pull/3473#issuecomment-3245269494 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

Re: [PR] Update org.eclipse.jetty*:* to v10.0.26 (branch_9x) [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3533: URL: https://github.com/apache/solr/pull/3533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency com.github.spotbugs:spotbugs-annotations to v4.9.4 (branch_9x) [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3538: URL: https://github.com/apache/solr/pull/3538#discussion_r231636 ## versions.props: ## @@ -7,7 +7,7 @@ com.carrotsearch:hppc=0.10.0 com.cybozu.labs:langdetect=1.1-20120112 com.fasterxml.jackson:jackson-bom=2.18.0 com.github.ben-ma

[PR] Remove unused method SolrCloudManager.request() [solr]

2025-09-03 Thread via GitHub
psalagnac opened a new pull request, #3599: URL: https://github.com/apache/solr/pull/3599 This removes `SolrCloudManager.request()` and implementations in Solr 10. @dsmiley tagging you as reviewer since you removed callers in SOLR-17630 and marked the method deprecated. --

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2313937099 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,572 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] SOLR-17891: Reorganize the DeprecatedSystemPropertyMappings file [solr]

2025-09-03 Thread via GitHub
epugh opened a new pull request, #3608: URL: https://github.com/apache/solr/pull/3608 https://issues.apache.org/jira/browse/SOLR-17891 Reorganize the mapping file to put the modern property on the left and the deprecated one on the left. Sort the file by the highlevel categ

Re: [PR] Update dependency no.nav.security:mock-oauth2-server to v2 (branch_9x) [solr]

2025-09-03 Thread via GitHub
janhoy commented on PR #3595: URL: https://github.com/apache/solr/pull/3595#issuecomment-3241042686 Closing as this would require JDK17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] SOLR-17806: Migrate SolrIndexWriter metrics to OTEL [solr]

2025-09-03 Thread via GitHub
cugarte commented on code in PR #3568: URL: https://github.com/apache/solr/pull/3568#discussion_r2317274766 ## solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java: ## @@ -177,66 +189,93 @@ private SolrIndexWriter( } else { mergeTotals = false; }

Re: [PR] Adding dependency graph submission workflow [solr]

2025-09-03 Thread via GitHub
ppkarwasz commented on PR #3502: URL: https://github.com/apache/solr/pull/3502#issuecomment-3245201303 > Should I include `branch_9x`. wdyt? It really depends on what you want to achieve. * **Dependency Graph:** GitHub only uses the graph from the **default branch** to determin

Re: [PR] SOLR-17780: Add support for scalar quantized dense vectors [solr]

2025-09-03 Thread via GitHub
liangkaiwen commented on PR #3385: URL: https://github.com/apache/solr/pull/3385#issuecomment-3245963319 @alessandrobenedetti updated + fixed tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] QueryRequest should only be for SearchHandler [solr]

2025-09-03 Thread via GitHub
dsmiley commented on PR #3518: URL: https://github.com/apache/solr/pull/3518#issuecomment-3246521972 I would very much welcome your improvement proposals to this PR, Jason :-). Thanks for the review. I'm a bit over-extended. -- This is an automated message from the Apache Git Service. T

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2316063996 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,572 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] SOLR-17806: Migrate Overseer and Blockcache metrics to OTEL [solr]

2025-09-03 Thread via GitHub
mlbiscoc opened a new pull request, #3607: URL: https://github.com/apache/solr/pull/3607 https://issues.apache.org/jira/browse/SOLR-17806 Migrate Overseer and block cache metrics. Block cache doesn't seem to be used at the moment since the removal of HDFS module but still migrated it

Re: [PR] Update plugin com.diffplug.spotless to v7 (branch_9x) [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3583: URL: https://github.com/apache/solr/pull/3583#discussion_r2316301880 ## build.gradle: ## @@ -26,7 +26,7 @@ plugins { id 'de.thetaphi.forbiddenapis' version '3.9' apply false id 'de.undercouch.download' version '5.6.0' apply false

Re: [PR] Update plugin com.github.node-gradle.node to v7.1.0 (branch_9x) [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3564: URL: https://github.com/apache/solr/pull/3564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update org.apache.kafka:* to v4 (branch_9x) (major) [solr]

2025-09-03 Thread via GitHub
janhoy closed pull request #3580: Update org.apache.kafka:* to v4 (branch_9x) (major) URL: https://github.com/apache/solr/pull/3580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-03 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2315316958 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,590 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17770: Modernize jetty xml files [solr]

2025-09-03 Thread via GitHub
dsmiley commented on PR #3377: URL: https://github.com/apache/solr/pull/3377#issuecomment-3243158562 Let's get this merged for Solr 10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Update dependency com.google.j2objc:j2objc-annotations to v3.1 [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3481: URL: https://github.com/apache/solr/pull/3481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v2.47 (branch_9x) [solr]

2025-09-03 Thread via GitHub
cpoerschke commented on code in PR #3556: URL: https://github.com/apache/solr/pull/3556#discussion_r2316317660 ## versions.props: ## @@ -66,7 +66,7 @@ org.eclipse.jetty.toolchain:jetty-servlet-api=4.0.6 org.glassfish.hk2*:*=3.1.1 org.glassfish.hk2.external:jakarta.inject=2.6.1

Re: [PR] Update plugin com.palantir.consistent-versions to v3 (branch_9x) [solr]

2025-09-03 Thread via GitHub
solrbot commented on PR #3598: URL: https://github.com/apache/solr/pull/3598#issuecomment-3242884251 ### Renovate Ignore Notification Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for *any* future `3.x` releases. But if you manuall

Re: [PR] Update plugin de.undercouch.download to v5.6.0 (branch_9x) [solr]

2025-09-03 Thread via GitHub
janhoy merged PR #3570: URL: https://github.com/apache/solr/pull/3570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17806: Migrate SolrIndexWriter metrics to OTEL [solr]

2025-09-03 Thread via GitHub
cugarte commented on code in PR #3568: URL: https://github.com/apache/solr/pull/3568#discussion_r2317270488 ## solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java: ## @@ -177,66 +189,93 @@ private SolrIndexWriter( } else { mergeTotals = false; }

Re: [PR] SOLR-17664: Set a cluster Solr Version [solr]

2025-09-03 Thread via GitHub
dsmiley closed pull request #3431: SOLR-17664: Set a cluster Solr Version URL: https://github.com/apache/solr/pull/3431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] SOLR-17872: Remove org.apache.http dependency from compile scope [solr]

2025-09-02 Thread via GitHub
dsmiley merged PR #3498: URL: https://github.com/apache/solr/pull/3498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17552: NamedList.asShallowMap improvements [solr]

2025-09-02 Thread via GitHub
dsmiley closed pull request #3050: SOLR-17552: NamedList.asShallowMap improvements URL: https://github.com/apache/solr/pull/3050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-02 Thread via GitHub
dsmiley commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2317770682 ## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ## @@ -905,7 +906,84 @@ protected boolean addFL(StringBuilder fl, String field, boolean addit

Re: [PR] Update dependency com.google.errorprone:error_prone_annotations to v2.41.0 (branch_9x) [solr]

2025-09-02 Thread via GitHub
solrbot commented on PR #3539: URL: https://github.com/apache/solr/pull/3539#issuecomment-3244343942 ### Renovate Ignore Notification Because you closed this PR without merging, Renovate will ignore this update (`2.41.0`). You will get a PR once a newer version is released. To ignore

[PR] Fix flaky test TestCollapseQParserPlugin.testMultiSort [solr]

2025-09-02 Thread via GitHub
dsmiley opened a new pull request, #3609: URL: https://github.com/apache/solr/pull/3609 Relying on index order is unreliable. http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.search.TestCollapseQParserPlugin.testMultiSort ```

Re: [PR] [exploratory] abstract QueryComponent.mergeIds' ShardDoc processing [solr]

2025-09-02 Thread via GitHub
cpoerschke commented on PR #3565: URL: https://github.com/apache/solr/pull/3565#issuecomment-3242830887 merged into https://github.com/apache/solr/pull/3418/commits branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Update dependency org.openapi.generator to v7.14.0 [solr]

2025-09-02 Thread via GitHub
janhoy merged PR #3109: URL: https://github.com/apache/solr/pull/3109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-02 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2315946946 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,590 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Update actions/setup-java action to v5 [solr]

2025-09-02 Thread via GitHub
janhoy merged PR #3606: URL: https://github.com/apache/solr/pull/3606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update plugin com.palantir.consistent-versions to v3 (branch_9x) [solr]

2025-09-02 Thread via GitHub
janhoy commented on PR #3598: URL: https://github.com/apache/solr/pull/3598#issuecomment-3242597334 Closing, as this v3 version requires JDK17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update opentelemetry to v1.53.0 [solr]

2025-09-02 Thread via GitHub
janhoy merged PR #3165: URL: https://github.com/apache/solr/pull/3165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency org.apache.commons:commons-collections4 to v4.5.0 (branch_9x) [solr]

2025-09-02 Thread via GitHub
janhoy merged PR #3545: URL: https://github.com/apache/solr/pull/3545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update apache.kafka to v3.9.1 [solr]

2025-09-02 Thread via GitHub
cpoerschke commented on PR #3364: URL: https://github.com/apache/solr/pull/3364#issuecomment-3245942797 * https://downloads.apache.org/kafka/3.9.1/RELEASE_NOTES.html * https://kafka.apache.org/blog#apache_kafka_391_release_announcement -- This is an automated message from the Apache Git

Re: [PR] Update org.glassfish.jersey*:* to v3.1.11 (branch_9x) [solr]

2025-09-02 Thread via GitHub
janhoy merged PR #3534: URL: https://github.com/apache/solr/pull/3534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update org.apache.kafka:* to v3.9.1 (branch_9x) [solr]

2025-09-02 Thread via GitHub
cpoerschke commented on PR #3530: URL: https://github.com/apache/solr/pull/3530#issuecomment-3245706956 #3364 is the not-yet merged equivalent update for `main` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] SOLR-17319 : Combined Query Feature for Multi Query Execution [solr]

2025-09-02 Thread via GitHub
ercsonusharma commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2315942209 ## solr/core/src/java/org/apache/solr/handler/component/CombinedQueryComponent.java: ## @@ -0,0 +1,590 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-17715: Deprecate SolrQuery.setRequestHandler [solr]

2025-09-02 Thread via GitHub
dsmiley merged PR #3600: URL: https://github.com/apache/solr/pull/3600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

  1   2   3   4   5   6   7   8   9   10   >