[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-02-02 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r797814806 ## File path: solr/bin/solr ## @@ -2264,6 +2264,7 @@ function start_solr() { # users who don't care about useful error msgs can override in SOLR_OPT

[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-26 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r793098853 ## File path: solr/contrib/build.gradle ## @@ -0,0 +1,77 @@ +import groovy.json.JsonOutput +import org.gradle.api.internal.artifacts.dependencies.Default

[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-26 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r792884314 ## File path: solr/contrib/scripting/manifest.json ## @@ -0,0 +1,22 @@ +{ +"version-constraint": "10", Review comment: What is the point of v

[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-26 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r792881998 ## File path: gradle/solr/packaging.gradle ## @@ -60,7 +60,11 @@ configure(allprojects.findAll {project -> project.path.startsWith(":solr:contrib /

[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-25 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r791131452 ## File path: solr/core/src/test/org/apache/solr/pkg/TestPackages.java ## @@ -61,6 +61,7 @@ import org.junit.Before; import org.junit.Test; +import j

[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-24 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r791131452 ## File path: solr/core/src/test/org/apache/solr/pkg/TestPackages.java ## @@ -61,6 +61,7 @@ import org.junit.Before; import org.junit.Test; +import j