HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1591495743
I reverted [SOLR-16816](https://issues.apache.org/jira/browse/SOLR-16816),
since the functionality was taken care of in this PR. I included the added
tests and testing changes from tha
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1590005050
Ok each plugin should have a good amount of docs to explain what is going on.
This should be ready to go IMO.
--
This is an automated message from the Apache Git Service.
To re
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1589689966
I've added tests and docs for the new API. Will probably merge in a day or
two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1588135823
Thanks for the review Radu!
> I saw a "parallel" flag, but I think replicas are moved one at a time,
correct? If so, it will likely prove to be a bottleneck down the road.
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1584658161
I also want to point out that the balanceReplicas logic is _decent_, it's
not perfect.
In the affinityPlugin, adding/removing replicas from a Node will change the
weights of oth
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1584636842
Awesome, I'm so glad this weighted approach is a good path to go down.
Should be even easier to add new PlacementPlugins, and we get balanceReplicas
for "free". I can't even imagine tr
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1583323386
I'm pretty sure we can revert https://github.com/apache/solr/pull/1661
([SOLR-16816](https://issues.apache.org/jira/browse/SOLR-16816)), if we merge
this with the existing functionalit
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1582636541
@radu-gheorghe if you are interested!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1582635343
So this should be ready to start reviewing.
It still needs testing and docs, but I don't want to do that until the
design has a +1 from others.
This PR now shifts the exis
HoustonPutman commented on PR #1650:
URL: https://github.com/apache/solr/pull/1650#issuecomment-1568534050
Yeah not ready for a review yet, still deciding on whether this is the right
way to go or not. Thanks for checking though!
--
This is an automated message from the Apache Git Service
10 matches
Mail list logo
