HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1020275508
@ijioio Let me know if you are ok with the name, i'll go ahead and backport
to other branches. If not I can fix the name then backport!
--
This is an automated message from
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1020190066
> The most work is done by you ))) Thanks!
But we always try to give out credit to all involved! I will use @ijioio
unless you have another name you prefer 🙂
--
This
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1018906578
This is good to go, minus a ChangeLog entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1018906313
Ok, I brought over that change from #549, so now this PR adds the
non-incremental backup response, and correctly merges the responses for async
and non-async calls.
--
This
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-101098
I also added in the incremental backup information `indexFileCount`,
`uploadedIndexFileCount`, `uploadedIndexFileMB` and `shardBackupIds` in the
aggregated response. (if they
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1017914278
@ijioio What name do you want used when I add a Changelog entry for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1017821168
The change from 'Response' to 'msg' turned out to be very easy and didn't
affect much else, so I went ahead and did it. This also allowed me to remove
the `RESPONSE` variable,
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1010097795
> Just to clarify, you're talking about backup format (Response update to
use NamedList instead of String) or about aggregated part of the response
(switching from array to di
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1007509659
@ijioio I think this would be great to get into 9.0, because of the
backwards incompatibility. 9.0 currently has a feature freeze, but I'm fine
arguing for this as a blocker a
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1007509659
@ijioio I think this would be great to get into 9.0, because of the
backwards incompatibility. 9.0 currently has a feature freeze, but I'm fine
arguing for this as a blocker a
HoustonPutman commented on pull request #479:
URL: https://github.com/apache/solr/pull/479#issuecomment-1005855293
> Yes, if the response format were to change that would need to be clearly
communicated to users e.g. via the
https://github.com/apache/solr/blob/main/solr/CHANGES.txt and/or
11 matches
Mail list logo
