[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-19 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1016657387 I refactor the documentation contribution, changing the name of the section to "Dense Vector Search". Whenever in the future we add some additional neural search techn

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-19 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1016416766 I should have addressed most of the comments regarding the documentation. Thank you very much for the suggestions @ctargett , they are really valuable, especially for

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-18 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1015606008 > Thanks, @cpoerschke for the thoughtful review, I committed all your suggestions! And the most recent pass as well :) -- This is an automated message from the

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880

2022-01-18 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1015427794 Thanks, @cpoerschke for the thoughtful review, I committed all your suggestions! -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880

2022-01-10 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1009250478 hi @msokolov , I just updated the Pull Request with the support for maxConn and beamWidth customization. According to what Lucene currently exposes I believe it's t

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880

2021-12-30 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1003079734 Done another iteration, with quite a good quantity of changes. Many issues related with the serialization/deserialization should be solved. I'll take a look after new

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880

2021-12-29 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1002617717 @msokolov thanks for the very good insights. I proceeded with an extensive work of analysis for the serialization/deserialization, especially investigating the availab

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880

2021-12-27 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1001609366 thanks @msokolov for your initial feedback! me and @eliaporciani will think about it and design some changes in the next few days! -- This is an automated message f

[GitHub] [solr] alessandrobenedetti commented on pull request #476: SOLR-15880

2021-12-24 Thread GitBox
alessandrobenedetti commented on pull request #476: URL: https://github.com/apache/solr/pull/476#issuecomment-1000895545 The Pull Request is now complete and ready for review. Adding @ctargett to the loop as there are plenty of documentation additions. Merry Christmas :D -- This i