[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1159424945 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExcepti

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1145083082 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -228,20 +230,20 @@ public List fetchInstalledPackageInstances() throws SolrExc public

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1145069656 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExcepti

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1145069656 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExcepti

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1127688733 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -582,59 +571,41 @@ public static boolean checkCommunicationError(Exception exc) { Throwable rootCause

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126768208 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126325809 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126325809 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126325809 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126310561 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -268,19 +270,21 @@ public Map getPackagesDeployedAsClusterLevelPlugins MultiValuedMa

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126305516 ## solr/core/src/test/org/apache/solr/cloud/SolrCloudExampleTest.java: ## @@ -222,109 +217,111 @@ protected void doTestDeleteAction(String testCollectionName, String sol

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126287118 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExcepti

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035705543 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -968,38 +978,39 @@ public Map getStatus(String solrUrl) throws Exception { if (!solrUrl.endsWith(

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035704235 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -968,38 +978,39 @@ public Map getStatus(String solrUrl) throws Exception { if (!solrUrl.endsWith(

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035700491 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -618,6 +623,10 @@ private static boolean exceptionIsAuthRelated(Exception exc) { && Arrays.asList

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1028346326 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -1059,12 +1080,38 @@ public Option[] getOptions() { protected void runImpl(CommandLine cli) throws Exc

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1028344331 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -968,38 +983,42 @@ public Map getStatus(String solrUrl) throws Exception { if (!solrUrl.endsWith(