bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1510826469
Thank you @epugh for looking after this PR, it was a lot of help! Also
thanks to @dsmiley and @risdenk for the reviews!
--
This is an automated message from the Apache Git Service.
To res
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1508375380
Woow somehow having a broken CreateCoreTool did not cause this test to fail,
but since the safeCheckCoreExists was also broken when the CreateCoreTool got
fixed it broke the test.
Nice
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1504797021
Thank you @epugh for looking into this!
I have reviewed the test failures and uploaded a fix for the solr core
creation.
The failures connected to restart were the consequences of
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1500206592
I have exported my notes about the testing that I have executed, in the
beginning there are the failed tests which I will have to look into, later
there are all the tests with the command a
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1499143172
gradle check was successful, I pushed the rebased commits. I am starting the
manual testing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1497321076
Thank you @epugh for having a look at this!
I was just about to do some manual testing and rebase this PR to the current
master, unfortunately I had lots of other stuff on my plate re
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1479921161
I am right now working on a bigger cleanup because there is plenty to do and
afterwards if you are also happy with how this looks I am all in for starting
the testing.
--
This is an auto
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1477557782
Do you recon I should revert the changes already made to the
`DistribPackageStore` class? Initially I changed the client to jetty because
the test was failing with json type `writeRaw` func
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1476344039
I have extracted an existing ResponseParser which parsed JSON responses and
using that I was able to work around the hack which we talked about in
Http2SolrClient, but this raised another c
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1453772240
Sorry that an update from me took so long, I was pretty stuck on a problem
regarding the package manager.
Now I have uploaded a new commit which resolved that problem and also
remove
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1354572598
I have added some more commits where I was trying to migrate from apache
client to the jetty client, but right now I am a bit stuck and I would need a
little guidance.
With the curre
11 matches
Mail list logo
