chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-1006908991
> `PlacementRequestImpl.toPlacementRequest` needs to be updated (when nodes
are passed in and when not) to filter out nodes that can't take data.
Fixed, thanks.
--
This is
chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-999221193
Addressed some comments from Ilan. TODO: Address some others from Ilan and
Jan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-996551502
This is now ready for review. FYI, @murblanc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-971621437
> Making sure we agree on the fact that nodes without defined roles are
assumed to have all roles, not only data role.
As discussed on the SIP thread (mainly during a back and
chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-971607650
TODO items:
* deprecate ADDROLE and REMOVEROLE commands
* throw exception when a node containing cores is started without a data role
* the /api/cluster/roles should also list
chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-971457263
> While you're at it Ishan, please fix the formatting of the many if(...
that lack a space after the if and change them into:
Sure, Ilan. :-)
--
This is an automated message
chatman commented on pull request #403:
URL: https://github.com/apache/solr/pull/403#issuecomment-971449610
In this PR, only a single role can be assigned to a node, and I'm fixing
that. Changes to come soon, hence this is not yet ready for reviewing. Sorry
for the confusion.
--
This is
