[GitHub] [solr] colvinco commented on pull request #1321: SOLR-13396 - Add property to disable deletion of unknown cores

2023-06-27 Thread via GitHub
colvinco commented on PR #1321: URL: https://github.com/apache/solr/pull/1321#issuecomment-1609909574 Based on what we've discussed previously and what @elyograg said on Slack, it seems like disabling it by default is reasonable. -- This is an automated message from the Apache Git Service

[GitHub] [solr] colvinco commented on pull request #1321: SOLR-13396 - Add property to disable deletion of unknown cores

2023-06-05 Thread via GitHub
colvinco commented on PR #1321: URL: https://github.com/apache/solr/pull/1321#issuecomment-1576980769 Sorry it's taken a long time, I've finally got back to this. See what you think? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [solr] colvinco commented on pull request #1321: SOLR-13396 - Add property to disable deletion of unknown cores

2023-04-03 Thread via GitHub
colvinco commented on PR #1321: URL: https://github.com/apache/solr/pull/1321#issuecomment-1493929189 Where do you think this would fit best into the Reference Guide? I've not seen an obvious section to add it to, it doesn't feel big enough to get its own page, and I don't think there's a p

[GitHub] [solr] colvinco commented on pull request #1321: SOLR-13396 - Add property to disable deletion of unknown cores

2023-02-01 Thread via GitHub
colvinco commented on PR #1321: URL: https://github.com/apache/solr/pull/1321#issuecomment-1412401969 > I'm ok with either _preserve_ or _delete_. If you rather want _delete_ then choose it, with a java-level default of "true". > > Do we need to treat this behaviour as a backward comp