[GitHub] [solr] cpoerschke commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r639920160 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +201,137 @@ public float getMaxScore(int upTo) thro

[GitHub] [solr] cpoerschke commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r638763122 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +201,137 @@ public float getMaxScore(int upTo) thro

[GitHub] [solr] cpoerschke commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r637917344 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode

[GitHub] [solr] cpoerschke commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r637903714 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -83,18 +104,52 @@ public FeatureWeight createWeight(IndexS

[GitHub] [solr] cpoerschke commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636516706 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r635980115 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633135019 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java ## @@ -56,11 +62,13 @@ public void before() throws Exception

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633712857 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java ## @@ -56,11 +62,13 @@ public void before() throws Exception

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633701951 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -106,18 +106,29 @@ public FieldValueFeatureWeight(IndexSea

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633135019 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java ## @@ -56,11 +62,13 @@ public void before() throws Exception

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r632990383 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -106,18 +106,29 @@ public FieldValueFeatureWeight(IndexSea

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r632769663 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -57,50 +67,79 @@ public void setField(String field) { }

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r632759790 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -232,58 +249,113 @@ private void createCollection(String name, Str

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631256745 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) thro