[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-09-29 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r718295807 ## File path: solr/CHANGES.txt ## @@ -466,6 +466,8 @@ Other Changes * SOLR-15599: woodstox-core-asl:4.4.1 (org.codehaus) replaced with woodstox-core:6.2

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-09-29 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r718313344 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/io/TupleTest.java ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-09-29 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r718295807 ## File path: solr/CHANGES.txt ## @@ -466,6 +466,8 @@ Other Changes * SOLR-15599: woodstox-core-asl:4.4.1 (org.codehaus) replaced with woodstox-core:6.2

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-09-09 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r705511096 ## File path: solr/CHANGES.txt ## @@ -466,6 +466,8 @@ Other Changes * SOLR-15599: woodstox-core-asl:4.4.1 (org.codehaus) replaced with woodstox-core:6.2

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-09-07 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r703432000 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2)

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-19 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r692345700 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2)

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-11 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r687023177 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2)

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-11 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r687023177 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2)

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-11 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r687023922 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2)

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-11 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r687023177 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2)

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-10 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r686186391 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -275,15 +295,32 @@ public void setMetrics(Map> metrics) { } publi

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-05 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r683291659 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -276,14 +282,12 @@ public void setMetrics(Map> metrics) { public Tup

[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

2021-08-05 Thread GitBox
cpoerschke commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r683291659 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -276,14 +282,12 @@ public void setMetrics(Map> metrics) { public Tup