[GitHub] [solr] cpoerschke commented on pull request #1873: Removing List.toArray calls with pre-sized Arrays

2023-09-08 Thread via GitHub
cpoerschke commented on PR #1873: URL: https://github.com/apache/solr/pull/1873#issuecomment-1712037914 https://lists.apache.org/thread/ybmp5xz3c9549opqgktdb4cxlpmdmwy4 (I think) is the dev list thread w.r.t. Crave.io CI patch application. -- This is an automated message from the Apache G

[GitHub] [solr] cpoerschke commented on pull request #1873: Removing List.toArray calls with pre-sized Arrays

2023-09-04 Thread via GitHub
cpoerschke commented on PR #1873: URL: https://github.com/apache/solr/pull/1873#issuecomment-1705524540 > ... (#error: patch failed: solr/core/src/java/org/apache/solr/cli/AssertTool.java:35 Hmm, I saw on the dev-list some thread(s) w.r.t. the crave CI but didn't follow too closely a

[GitHub] [solr] cpoerschke commented on pull request #1873: Removing List.toArray calls with pre-sized Arrays

2023-09-04 Thread via GitHub
cpoerschke commented on PR #1873: URL: https://github.com/apache/solr/pull/1873#issuecomment-1705005303 > hmm, now JavaSpotless check is failing on a class I have not touched, this one: > src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java Hi @rena