[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-09-28 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-929215631 > So I'll just wait on the other issue to get resolved then? Any TO-DOs before then? No TO-DOs that I can think of, thanks for the ping! Once the other issue is resolved

[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-09-28 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-929215631 > So I'll just wait on the other issue to get resolved then? Any TO-DOs before then? No TO-DOs that I can think of, thanks for the ping! Once the other issue is resolved

[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-09-06 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-913644039 > Hmm, running the full test suite locally via `./gradlew test` gives two reproducible failures: ... This is, I think, because the `@JsonProperty` annotations don't yet

[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-09-03 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-912684782 Hmm, running the full test suite locally via `./gradlew test` gives two reproducible failures: ``` gradlew :solr:core:test --tests

[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-09-02 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-911854652 Thanks @bitnahian for completing the test TO-DO items! I just added two commits to the branch: * @gus-asf's suggestion to deprecate the Integer method variant * a

[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-08-13 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-898673372 > Attempted to run tests under org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java but tests are currently ignored. Looks like

[GitHub] [solr] cpoerschke commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-08-12 Thread GitBox
cpoerschke commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-897714718 Thanks @bitnahian for opening this pull request! I'm not really familiar with this area of the code but via `git grep` noticed that