[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

2022-06-01 Thread GitBox
cpoerschke commented on PR #886: URL: https://github.com/apache/solr/pull/886#issuecomment-1143908205 > okay, digging in some more so amending the `purgeParams` calls works I think, making the `spatial` checkbox similar to the `dismax` and `edismax` dropdown options. WDYT? -- This

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

2022-06-01 Thread GitBox
cpoerschke commented on PR #886: URL: https://github.com/apache/solr/pull/886#issuecomment-1143876246 > ... getDependentFields("spatial")` logic which might break if the `spatial.` prefix is simply dropped? ... okay, so experimentally, when the `spatial` checkbox is unchecked then it

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

2022-06-01 Thread GitBox
cpoerschke commented on PR #886: URL: https://github.com/apache/solr/pull/886#issuecomment-1143867832 Hmm, I'm not very familiar with this code but from trying to learn via the #122 diff there is I see at https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/webapp/web/js/angular/con

[GitHub] [solr] cpoerschke commented on pull request #886: SOLR-16142: Fix Admin UI's spatial parameter generation.

2022-06-01 Thread GitBox
cpoerschke commented on PR #886: URL: https://github.com/apache/solr/pull/886#issuecomment-1143855301 Perhaps last minute candidate for 8.11.2 if this fix is accurate? cc/fyi @madrob -- This is an automated message from the Apache Git Service. To respond to the message, please log on to