[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r65107 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -560,10 +559,16 @@ public static void

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r66232 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -368,6 +368,7 @@ public void call(ClusterState

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r65107 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -560,10 +559,16 @@ public static void

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r651237184 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -560,10 +559,16 @@ public static void

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r651233427 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -370,7 +369,7 @@ public void call(ClusterState

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r645742672 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java ## @@ -233,6 +233,41 @@ public static ClusterState createFromJson(int version,

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r641833458 ## File path: solr/core/src/test/org/apache/solr/cloud/api/collections/SimpleCollectionCreateDeleteTest.java ## @@ -110,7 +110,7 @@ public void

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r594760829 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CollApiCmds.java ## @@ -226,8 +226,8 @@ public void call(ClusterState clusterState,