[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r604847464 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -748,7 +748,12 @@ public void load() { warnUsersOfInsecureSettings();

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r604372030 ## File path: solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java ## @@ -62,7 +60,13 @@ public String configSetName(CoreDescriptor cd) {

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r604371316 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -57,7 +57,7 @@ public static ConfigSetService

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r604034499 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -344,8 +344,9 @@ protected NamedList loadConfigSetFlags(CoreDescriptor cd,

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r603761380 ## File path: solr/core/src/java/org/apache/solr/core/backup/BackupManager.java ## @@ -296,51 +293,45 @@ public void downloadCollectionProperties(String

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r603509754 ## File path: solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java ## @@ -1216,15 +1212,15 @@ public void testList() throws Exception { * *

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r603502495 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkCLI.java ## @@ -242,8 +243,7 @@ public static void main(String[] args) throws InterruptedException,

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r603243000 ## File path: solr/core/src/java/org/apache/solr/cloud/OverseerConfigSetMessageHandler.java ## @@ -340,7 +320,7 @@ private void createConfigSet(ZkNodeProps

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602656335 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -781,6 +785,14 @@ public String getConfig() { } } + public

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602653831 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -276,20 +270,11 @@ public void downloadConfig(String configName, Path dir)

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r602575524 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -295,9 +248,9 @@ public void downloadConfig(String configName, Path dir)

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r601875746 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -191,19 +213,79 @@ public void uploadConfig(Path dir, String configName)

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r601012351 ## File path: solr/core/src/java/org/apache/solr/core/backup/BackupManager.java ## @@ -287,6 +293,51 @@ public void downloadCollectionProperties(String

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r599225946 ## File path: solr/core/src/java/org/apache/solr/cloud/OverseerCollectionConfigSetProcessor.java ## @@ -88,9 +88,9 @@ private static

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r598745515 ## File path: solr/core/src/java/org/apache/solr/core/backup/BackupManager.java ## @@ -253,7 +253,7 @@ public void downloadConfigDir(String configName) throws

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r596508662 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -211,6 +215,73 @@ protected NamedList loadConfigSetFlags(CoreDescriptor cd,

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r596028789 ## File path: solr/contrib/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrFileSystemConfigSetServiceScraperTest.java ## @@ -40,7 +40,7 @@