[GitHub] [solr] dsmiley commented on a change in pull request #255: SOLR-15560: Optimize JavaBinCodec encode/decode performance.

2021-09-08 Thread GitBox
dsmiley commented on a change in pull request #255: URL: https://github.com/apache/solr/pull/255#discussion_r704916042 ## File path: solr/benchmark/build.gradle ## @@ -69,6 +69,8 @@ private static String toPath(Set classpathUnderTest) { dependencies { implementation

[GitHub] [solr] dsmiley commented on a change in pull request #255: SOLR-15560: Optimize JavaBinCodec encode/decode performance.

2021-08-27 Thread GitBox
dsmiley commented on a change in pull request #255: URL: https://github.com/apache/solr/pull/255#discussion_r697624329 ## File path: solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java ## @@ -935,9 +1046,7 @@ private CharSequence _readStr(DataInputInputStream