[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r723654321 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724149383 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724146920 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724146920 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724146043 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-06 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r723654321 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-06 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r723257144 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -751,6 +751,7 @@ public void load() { warnUsersOfInsecureSettings(); t

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-09-30 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r719579038 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -54,6 +54,28 @@ public static ConfigSetService createConfigSetService(Co