[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-12-05 Thread GitBox
dsmiley commented on code in PR #1048: URL: https://github.com/apache/solr/pull/1048#discussion_r1040413560 ## solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java: ## @@ -1205,7 +1205,6 @@ private void doDefensiveChecks(DistribPhase phase) {

[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-09-29 Thread GitBox
dsmiley commented on code in PR #1048: URL: https://github.com/apache/solr/pull/1048#discussion_r983869369 ## solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java: ## @@ -741,16 +766,29 @@ public boolean split(ClusterState clusterState, ZkNodeProps