dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1306288103
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientProxyTest.java:
##
Review Comment:
@stillalex please take a look at my changes here and let me
dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1285847169
##
solr/test-framework/src/java/org/apache/solr/util/SolrJettyTestRule.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1118128772
##
solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSuggesterResponse.java:
##
@@ -119,8 +119,8 @@ public void testEmptySuggesterResponse() throws Exception {
dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1118019036
##
solr/core/src/test/org/apache/solr/request/TestRemoteStreaming.java:
##
@@ -116,7 +116,7 @@ public void testNoUrlAccess() throws Exception {
SolrQuery query = new
dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1117988442
##
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##
@@ -135,14 +135,16 @@ protected void create(NewCollectionBuilder b) throws
SolrServerExce
dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1117980789
##
solr/core/src/test/org/apache/solr/TestSolrCoreProperties.java:
##
@@ -93,7 +91,7 @@ public void testSimple() throws Exception {
params(
"q", "*:*
