[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-09 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1044864840 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -148,4 +283,12 @@ protected Long getCurrentSchemaModificationVersion( return null;

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-06 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1041330103 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -287,11 +285,9 @@ public Long getCurrentSchemaModificationVersion( } protected

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-05 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1040336243 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -287,9 +287,11 @@ public Long getCurrentSchemaModificationVersion( } protected

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-01 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1037645351 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -148,4 +284,13 @@ protected Long getCurrentSchemaModificationVersion( return null;

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-12-01 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1037644274 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -148,4 +284,13 @@ protected Long getCurrentSchemaModificationVersion( return null;

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-11-30 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1036604971 ## solr/core/src/test/org/apache/solr/core/TestFileSystemConfigSetService.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-11-29 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1035241026 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -16,35 +16,54 @@ */ package org.apache.solr.core; +import static