[GitHub] [solr] dsmiley commented on a diff in pull request #1625: SOLR-16507: Refactor out ImplicitSnitch

2023-05-26 Thread via GitHub
dsmiley commented on code in PR #1625: URL: https://github.com/apache/solr/pull/1625#discussion_r1206888331 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/NodeValueFetcher.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [solr] dsmiley commented on a diff in pull request #1625: SOLR-16507: Refactor out ImplicitSnitch

2023-05-09 Thread via GitHub
dsmiley commented on code in PR #1625: URL: https://github.com/apache/solr/pull/1625#discussion_r1188562791 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java: ## @@ -221,110 +217,18 @@ static void fetchReplicaMetrics( @Overrid

[GitHub] [solr] dsmiley commented on a diff in pull request #1625: SOLR-16507: Refactor out ImplicitSnitch

2023-05-04 Thread via GitHub
dsmiley commented on code in PR #1625: URL: https://github.com/apache/solr/pull/1625#discussion_r1185084634 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/MetricsFetcher.java: ## @@ -0,0 +1,202 @@ +package org.apache.solr.client.solrj.impl; + +import java.uti