[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965992444 ## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965990273 ## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965987977 ## solr/core/src/test/org/apache/solr/handler/configsets/ListConfigSetsAPITest.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-07 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965317709 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("applic

[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-07 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965280828 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -388,33 +335,65 @@ public CompositeApi add(Api api) { } } + // We don't rely on any of Jersey's au

[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-05 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r962080721 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -184,7 +185,7 @@ * to make it work. When multi-core support was added to Solr way back in version 1.3, this

[GitHub] [solr] dsmiley commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-22 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r952142394 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -157,20 +168,16 @@ public void call(SolrQueryRequest req, SolrQueryResponse rsp) { origCorename = p