[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-991257166 This wasn't done; it's follow-up tiny stuff. @NazerkeBS there are a couple things remaining I asked of you -- the empty catch, and loadConfigSetProperties -- This is an automated

[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-991257166 This wasn't done; it's follow-up tiny stuff. @NazerkeBS there are a couple things remaining I asked of you -- the empty catch, and loadConfigSetProperties -- This is an automated

[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-883013519 > Is this an is or ought statement? "ought". It's a minor nuisance really. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-883013519 > Is this an is or ought statement? "ought". It's a minor nuisance really. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-883013519 > Is this an is or ought statement? "ought". It's a minor nuisance really. -- This is an automated message from the Apache Git Service. To respond to the message, please lo