[GitHub] [solr] dsmiley commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-26 Thread GitBox
dsmiley commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1022559062 Maybe we should delay this PR until after the module separation to be absolutely sure we only explode the dependencies in a module and not here in core. -- This is an automated m

[GitHub] [solr] dsmiley commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-26 Thread GitBox
dsmiley commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1022557589 I basically agree. That said, I hope you can go through the dependency tree to use the knowledge/intuition you have (or other x-Cloudera folks; whoever knows HDFS) to prune out stu

[GitHub] [solr] dsmiley commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-25 Thread GitBox
dsmiley commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1021837229 When doing any non-trivial change to dependencies (as was done here), I strongly recommend reading what Dawid wrote: `help/dependencies.txt`. In particular, I find this useful: