[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: Use Builder Pattern with Solr Clients

2022-12-02 Thread GitBox
epugh commented on code in PR #1158: URL: https://github.com/apache/solr/pull/1158#discussion_r1038648987 ## solr/core/src/test/org/apache/solr/search/TestSmileRequest.java: ## @@ -91,7 +90,6 @@ public void assertJQ(SolrClient client, SolrParams args, String... tests) //

[GitHub] [solr] epugh commented on a diff in pull request #1158: SOLR-16368: Use Builder Pattern with Solr Clients

2022-11-25 Thread GitBox
epugh commented on code in PR #1158: URL: https://github.com/apache/solr/pull/1158#discussion_r1032604734 ## solr/core/src/test/org/apache/solr/schema/TestCloudManagedSchema.java: ## @@ -53,21 +54,22 @@ public void test() throws Exception { QueryRequest request = new