[GitHub] [solr] epugh commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-22 Thread GitBox
epugh commented on code in PR #1220: URL: https://github.com/apache/solr/pull/1220#discussion_r1055635045 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean parallelUpdates) {

[GitHub] [solr] epugh commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-15 Thread GitBox
epugh commented on code in PR #1220: URL: https://github.com/apache/solr/pull/1220#discussion_r1049812581 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean parallelUpdates) {

[GitHub] [solr] epugh commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-15 Thread GitBox
epugh commented on code in PR #1220: URL: https://github.com/apache/solr/pull/1220#discussion_r1049801546 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java: ## @@ -34,6 +35,8 @@ protected boolean useMultiPartPost; protected Integer

[GitHub] [solr] epugh commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-15 Thread GitBox
epugh commented on code in PR #1220: URL: https://github.com/apache/solr/pull/1220#discussion_r1049793352 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean parallelUpdates) {

[GitHub] [solr] epugh commented on a diff in pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-15 Thread GitBox
epugh commented on code in PR #1220: URL: https://github.com/apache/solr/pull/1220#discussion_r1049791072 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean parallelUpdates) {