epugh commented on code in PR #1341: URL: https://github.com/apache/solr/pull/1341#discussion_r1100742588
########## solr/core/src/test/org/apache/solr/schema/TestBinaryField.java: ########## @@ -65,14 +60,14 @@ public static void beforeTest() throws Exception { new File(src_dir, "solrconfig.snippet.randomindexconfig.xml"), new File(confDir, "solrconfig.snippet.randomindexconfig.xml")); - try (Writer w = - new OutputStreamWriter( - Files.newOutputStream(collDir.toPath().resolve("core.properties")), - StandardCharsets.UTF_8)) { - Properties coreProps = new Properties(); - coreProps.put("name", "collection1"); - coreProps.store(w, ""); - } + // try (Writer w = Review Comment: this is nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org