[GitHub] [solr] epugh commented on a diff in pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-25 Thread via GitHub
epugh commented on code in PR #1785: URL: https://github.com/apache/solr/pull/1785#discussion_r1273448667 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -43,24 +68,295 @@ public String getName() { @Override public List getOptions() { -return CreateC

[GitHub] [solr] epugh commented on a diff in pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-25 Thread via GitHub
epugh commented on code in PR #1785: URL: https://github.com/apache/solr/pull/1785#discussion_r127358 ## solr/core/src/java/org/apache/solr/cli/CreateTool.java: ## @@ -43,24 +68,295 @@ public String getName() { @Override public List getOptions() { -return CreateC

[GitHub] [solr] epugh commented on a diff in pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-22 Thread via GitHub
epugh commented on code in PR #1785: URL: https://github.com/apache/solr/pull/1785#discussion_r1271340423 ## dev-tools/scripts/cloud.sh: ## @@ -341,7 +341,7 @@ start(){ -Dsolr.solrxml.location=zookeeper -Dsolr.log.dir=$CLUSTER_WD_FULL/n${i} $JVM_ARGS") FINAL_COMMAND="