[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-02-01 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1412256804 @stillalex I was hoping to merge this, but going to leave it open for another day and see if anyone has a tip on fixing the crave build...I don't believe the crave build error has

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-25 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1404038382 @magibney and I chatted, and we're going to leave it open till end of the week in case anyone else has concerns about having a potentially longer list of dynamic fields in the drop down ;-).

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400748206 > Sure! I can buy that. So... leave the todo? It otherwise looks good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400650619 > > I see the ? from the bool... I was trying to figure out if there is something we could put there, like "Bool" or something? But regardless, I like how this works... > > I would

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400648984 > I started thinking about another param... but that feels a bit like the `goto` statement of web dev. How hard would it be to change the query to submit when you click the button?

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400580787 https://user-images.githubusercontent.com/22395/214085226-599d3a5b-1b6d-40e5-a1d4-88355f5172f7.png;> Ahh... Now I see the `@todo` reasonI wonder if the right fix is to pick

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400570621 https://user-images.githubusercontent.com/22395/214083749-158ac761-ba50-4820-b221-5b52cd4293c6.png;> I see the `?` from the bool... I was trying to figure out if there is something we