[GitHub] [solr] epugh commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-08-06 Thread via GitHub
epugh commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1666952512 Some nice cleans up @dsmiley in the current round! The tests read much simpler... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [solr] epugh commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-02-26 Thread via GitHub
epugh commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1445406355 This is going to be great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] epugh commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-02-22 Thread via GitHub
epugh commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1440473853 Thanks for sharing the summary from the review... I think you answered some questions I had! Really looking forward to seeing this land ;-). -- This is an automated message from the Ap