[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-07-07 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1625839626 > @epugh I think this is causing test failures on main, https://github.com/apache/solr/actions/runs/5488487120/jobs/10001406829?pr=1766 I don't know how I missed this one.. I fixed it (

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-07-06 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1624338309 Final review... I plan on merging this to `main` on Friday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-06-29 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1613847169 @Willdotwhite you are quite right about the missing `/solr`, oops! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-06-29 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1613296492 ^ @Willdotwhite if you want to test the bin/solr.cmd post command! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-24 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1561186026 Okay, I think I am down to 1) Testing Solr Basic Auth handling, which I may treat seperately, and 2) Test my change to solr.cmd... Would love someone to confirm on windows that `bin/solr.cmd

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-17 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1551173472 Okay, I think this is getting there. I can't actually test extraction due to some sort of issue in actually using the `/update/extract` handler that I emailed the dev mailing list.I also

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-16 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1550515691 I think the extract function may be out of scope since I can't get the `/update/extract/` end point to work on Main.. Something is up with that The code in `bin/solr post` is properly

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-16 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1550514918 My 11 year old is reviewing this PR ;-) https://github.com/apache/solr/assets/22395/e71a39f4-53e6-4bd0-a163-293c94ecf8d4";> -- This is an automated message from the Apache Git Serv

[GitHub] [solr] epugh commented on pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-16 Thread via GitHub
epugh commented on PR #1634: URL: https://github.com/apache/solr/pull/1634#issuecomment-1549441434 @janhoy what do you think of calling this "IndexTool" instead of "PostTool" And `bin/solr index` versus `bin/solr post`I worry that post overlaps with api...?Though then I wo