epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1623990318
I *think* we are finally there... Responding to the last bits of feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1613846016
okay @Willdotwhite I had to restore a change to `StatusTool.java` to make it
work on Unix.. Is it possible that we have the .cmd and the .sh somewhat
working at cross purposes in how we deci
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1612190694
@Willdotwhite can we delete the method `status_usage` ? Line 282 has:
```
IF "%SCRIPT_CMD%"=="status" goto status_usage
```
--
This is an automated message from the Ap
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1611942622
@Willdotwhite I had a thought which is that maybe I'll back out the
`bin/solr status`command changes, since that was giving you some problems, and
move that to the Round 2 of work, which then
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1604503377
@Willdotwhite @mkhludnev so what is the best way to bring in the changes
that both of you have made?
https://github.com/apache/solr/compare/main...mkhludnev:solr:SOLR-16829 shows
some great
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1602578313
@mkhludnev I've chased down the latest merge conflicts ;-). Let me know
how it goes, and if you want to do a pairing session, I can jump on next week.
--
This is an automated message from
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1597362729
@mkhludnev right now it's a bit more then "just a test". I have made a lot
of changes to `bin/solr` and need the same changes applied to `bin/solr.cmd`
;-). The change was enoguh that I di
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1593682351
That is perfect !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1593588424
That would be perfect. This PR is ready for merging as soon as we have the
Windows side dealt with. There will be at least a Round 2, and maybe a Round
3 when we tackle `package` and `zk` c
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1592156395
More ambitious is this PR that I haven't tried to change the `solr.cmd` yet,
but it should mimic what was done in `solr`. cc @willdotwhite
--
This is an automated message from the Apache G
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1590988878
Tests all pass! I'd love to get some review on this so I can wrap it up
before I start tackling the rest of the Solr commands which may be tougher to
port... (looking at you bin/solr zk)
epugh commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1587223833
So... I'm starting to think this is a Solr 10 only change... There are
so many small cleanups and other awkwardnesses in the CLI, that making it work
in Solr 9 is going to cause a LOT of f
12 matches
Mail list logo
