[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)

2023-06-22 Thread via GitHub
epugh commented on PR #1688: URL: https://github.com/apache/solr/pull/1688#issuecomment-1602511534 thank you so MUCH @risdenk for untangling my commits. If couldn't tell, I was getting frustrated ;-). I've run things locally, so going to commit now. -- This is an automated message from

[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)

2023-06-20 Thread via GitHub
epugh commented on PR #1688: URL: https://github.com/apache/solr/pull/1688#issuecomment-1599140583 Looks like one bats test failing... ` not ok 39 deploying and undeploying of packages in 9987ms` -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)

2023-06-19 Thread via GitHub
epugh commented on PR #1688: URL: https://github.com/apache/solr/pull/1688#issuecomment-1597365359 I will commit this tomorrow hopefully... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)

2023-06-14 Thread via GitHub
epugh commented on PR #1688: URL: https://github.com/apache/solr/pull/1688#issuecomment-1592154572 @Willdotwhite I'd be happy to test out your Bats tests for you..If you get something down, even if it's rough, I can probably get it over the finish line. On an interesting side

[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)

2023-06-09 Thread via GitHub
epugh commented on PR #1688: URL: https://github.com/apache/solr/pull/1688#issuecomment-1584353387 @Willdotwhite how is progress? Any blockers/help you need? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)

2023-06-05 Thread via GitHub
epugh commented on PR #1688: URL: https://github.com/apache/solr/pull/1688#issuecomment-1576604635 i think, once you decide how you want to handle the tests side of this, that it is probably ready for committing ;-).. -- This is an automated message from the Apache Git Service. To resp