[GitHub] [solr] epugh commented on pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-25 Thread via GitHub
epugh commented on PR #1785: URL: https://github.com/apache/solr/pull/1785#issuecomment-1649751539 I have created https://issues.apache.org/jira/browse/SOLR-16903 to encourage migrating to Path everywhere -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] epugh commented on pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-22 Thread via GitHub
epugh commented on PR #1785: URL: https://github.com/apache/solr/pull/1785#issuecomment-1646667961 I think this PR is ready for committing to `main` and back porting to `branch_9x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [solr] epugh commented on pull request #1785: SOLR-16892: make CreateTool Cloud/Standalone Aware

2023-07-22 Thread via GitHub
epugh commented on PR #1785: URL: https://github.com/apache/solr/pull/1785#issuecomment-1646667718 > I see a lot of java.io.File usage here. Nowadays, the Path API should be used. Agreed.. I migrated the usage here, however I think it would be good to have a seperate ticket for maki