[GitHub] [solr] epugh commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1732324163 This is very exciting. And imagine in the future we could provide sane default configurations for `development` versus `production` deploys of Solr! Kind of like what we did with `bin/sol

[GitHub] [solr] epugh commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731280854 This is all looking really great @janhoy ... If the process of getting this done everywhere is a big job, make other jira's and maybe split them up by area so others can help? -- Thi

[GitHub] [solr] epugh commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1723905011 Would then the preferred access mode for getting properties be via `EnvUtils.getProp(SolrDispatchFilter.SOLR_DEFAULT_CONFDIR_ATTRIBUTE)` pattern? I could imagine in a future ticket getting r