[GitHub] [solr] epugh commented on pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

2023-09-25 Thread via GitHub
epugh commented on PR #1957: URL: https://github.com/apache/solr/pull/1957#issuecomment-1734238649 > @epugh re. `commons-cli` vs `argparse4j` I want to take a stab at rewriting, but I would like to do it as a part of a different PR as an improvement. for this PR i am focusing on resolving a

[GitHub] [solr] epugh commented on pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

2023-09-25 Thread via GitHub
epugh commented on PR #1957: URL: https://github.com/apache/solr/pull/1957#issuecomment-1734189390 > thank you for the review @epugh! > > > Awesome work @stillalex Have you looked at #1954 ([SOLR-14496](https://issues.apache.org/jira/browse/SOLR-14496)) where I took a stab at ad

[GitHub] [solr] epugh commented on pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

2023-09-25 Thread via GitHub
epugh commented on PR #1957: URL: https://github.com/apache/solr/pull/1957#issuecomment-1733998142 Awesome work @stillalex Have you looked at https://github.com/apache/solr/pull/1954 (SOLR-14496) where I took a stab at adding credentials to the SolrCLI? It would be great if we used