epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-918220552
Closing in favour of an updated PR https://github.com/apache/solr/pull/279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-910236316
Thank you everyone who reviewed code. I have spent the past few days
trying to figure out why tests are failing (that shouldn't have!!), and
started a NEW branch, where all of the
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-903250748
@janhoy I wonder if there will ever be enough use cases that we would want
to support some sort of "migrations" concept in Solr...A way of assisting
someone in an upgrade by runnin
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-903249838
THanks for the comments @dsmiley I will go through and make edits.I
*think* when I am done with this change, I'd like to revisit the ManagedSchema
codebase and see if there was som
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-903103237
Can I just say that all of this logic is very convoluted? We're
constantly checking what type of loader we have, we constantly manually create
the paths to lookup the schema resourc
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-901966934
--
This is an automated message from the Apache Git Service.
To respo
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-901966202
Doing some manual testing, and in non-solr cloud mode, if you have a
`managed-schema` file, and you modify the schema via SchemaAPI, then you now
have a `managed-schema.xml` alon
epugh commented on pull request #264:
URL: https://github.com/apache/solr/pull/264#issuecomment-901354917
I backed out the magic rename, but to get the tests to pass, I have to
check in THREE places the naming logic... ;-(.
I'm going to try and DRY it up, and would love any pointe
