epugh opened a new pull request, #1954: URL: https://github.com/apache/solr/pull/1954
https://issues.apache.org/jira/browse/SOLR-14496 # Description Add a new commmand line parameter `-credentials` (sometimes known as `-u`) in the format of: `-u eric:password` to enable basic auth support. # Solution Lots and LOTS of sprinkling of the `credentials` parameter all over the code ;-(. I thought there would be a much stronger single place to create a SolrClient, where I could add the credentials, and then it would all work. However that seems to not be the case, we create them all over the place in many different mways. I *did* discover the use of the magic variables in the solr config file that via some sort of "inject/systemproperty magic" allows basic auth to work on the actual solr box! It's somehow enabled with `bin/solr auth` command... See the bats test with how I hacked a workaround to NOT make that happen so I could test. # Tests Bats! # Checklist Please review the following and check all that apply: - [x ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x ] I have created a Jira issue and added the issue ID to my pull request title. - [x ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
