[GitHub] [solr] gerlowskija commented on a diff in pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2023-09-08 Thread via GitHub
gerlowskija commented on code in PR #1119: URL: https://github.com/apache/solr/pull/1119#discussion_r1319865106 ## solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotBackupAPI.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] gerlowskija commented on a diff in pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2022-10-26 Thread GitBox
gerlowskija commented on code in PR #1119: URL: https://github.com/apache/solr/pull/1119#discussion_r1006101772 ## solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java: ## @@ -0,0 +1,100 @@ +package org.apache.solr.handler.replication; + +import static org.apach

[GitHub] [solr] gerlowskija commented on a diff in pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2022-10-26 Thread GitBox
gerlowskija commented on code in PR #1119: URL: https://github.com/apache/solr/pull/1119#discussion_r1006099737 ## solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java: ## @@ -0,0 +1,100 @@ +package org.apache.solr.handler.replication; + +import static org.apach

[GitHub] [solr] gerlowskija commented on a diff in pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2022-10-26 Thread GitBox
gerlowskija commented on code in PR #1119: URL: https://github.com/apache/solr/pull/1119#discussion_r1006098487 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java: ## @@ -452,6 +454,11 @@ void call() throws Exception { } } + @Override Review Co

[GitHub] [solr] gerlowskija commented on a diff in pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2022-10-25 Thread GitBox
gerlowskija commented on code in PR #1119: URL: https://github.com/apache/solr/pull/1119#discussion_r1004311073 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java: ## @@ -452,6 +454,11 @@ void call() throws Exception { } } + @Override Review Co