[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1456812218 Force-pushes also break this really nice UI feature that Github has of, "Only show me what's changed since the last time I posted a review", fwiw. https://user-images.githubusercontent

[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1456769251 Hey, sorry for the delay in circling back to this @stillalex - will take a look shortly with a mind to commit. https://user-images.githubusercontent.com/9030708/223204161-5349de59-

[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-02-23 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1442275493 Alright, I fixed the ClusterAPI duplicate I mentioned, but in the process I found a few other things that were worth discussing here. Specifically, the response that comes back fro

[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-02-23 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1442139719 Small heads up for you @stillalex - I know it's tempting to force-push, but we've found that it can do weird things to Github comment history and make PRs just that bit harder to review.

[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-02-07 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1421221222 Hey, thanks for the PR Alex. A lot of these have been blocked for awhile on SOLR-16531, but that's close enough to closed out that we should be good to start transitioning APIs aga