[GitHub] [solr] gerlowskija commented on pull request #1649: SOLR-16395 JAX-RS conversion for /schema, uniqueKey, similarity and version

2023-05-30 Thread via GitHub
gerlowskija commented on PR #1649: URL: https://github.com/apache/solr/pull/1649#issuecomment-1568720455 Merged, thanks again @bszabo97 ! Will backport as long as the tests look OK in a few days or so -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] gerlowskija commented on pull request #1649: SOLR-16395 JAX-RS conversion for /schema, uniqueKey, similarity and version

2023-05-26 Thread via GitHub
gerlowskija commented on PR #1649: URL: https://github.com/apache/solr/pull/1649#issuecomment-1564592360 Awesome @bszabo97 , thanks for taking these on. Everything looks great as-is! I'm gonna spike out a few unit tests for these APIs (maybe using a `JerseyTest` base, or maybe using mocks