ixai opened a new pull request, #908:
URL: https://github.com/apache/solr/pull/908

   https://issues.apache.org/jira/browse/SOLR-16256
   
   # Description
   
   The documentation for the 
[AffinityPlacementFactory](https://solr.apache.org/guide/solr/latest/configuration-guide/replica-placement-plugins.html#configuration)
 states that the `nodeType` configuration key limits the nodes eligible for 
placement to only those that match one or more of the specified node types.
   
   The code for the 
[AffinityPlacementConfig](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java#L97)
 defines the key as `collectionNodeType` instead.
   
   # Solution
   
   Updated the documentation.
   
   Alternatively, I could've changed the code to match the docs. I can update 
the PR if asked.
   
   # Tests
   
   N/A
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to