[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2022-01-01 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r777123342 ## File path: solr/core/src/java/org/apache/solr/handler/admin/PropertiesRequestHandler.java ## @@ -75,4 +76,9 @@ public String getDescription() { public Ca

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2022-01-01 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r777123318 ## File path: solr/core/src/java/org/apache/solr/handler/admin/InfoHandler.java ## @@ -157,4 +158,17 @@ public SolrRequestHandler getSubHandler(String subPath)

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-21 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753722612 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -213,14 +212,14 @@ public void testBasicPermissions()

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753726238 ## File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java ## @@ -173,6 +173,7 @@ private boolean predefinedPermissionApp

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753723148 ## File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc ## @@ -80,6 +80,8 @@ All the usages are replaced by BaseHttpSolrClient.RemoteSolrException a

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753723020 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -213,14 +212,14 @@ public void testBasicPermissions()

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753722612 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -213,14 +212,14 @@ public void testBasicPermissions()