[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-09-05 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1315570191 ## solr/webapp/web/js/angular/services.js: ## @@ -286,8 +286,74 @@ solrAdminServices.factory('System', }) }]) .factory('AuthenticationService', -['base64', f

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-09-05 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1315545934 ## solr/webapp/web/js/angular/services.js: ## @@ -286,8 +286,74 @@ solrAdminServices.factory('System', }) }]) .factory('AuthenticationService', -['base64', f

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-22 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1301664112 ## solr/webapp/web/js/angular/services.js: ## @@ -286,8 +286,74 @@ solrAdminServices.factory('System', }) }]) .factory('AuthenticationService', -['base64', f

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-22 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1301661134 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-22 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1301171535 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-17 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1296859919 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-17 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1297041120 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-17 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1296859919 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-17 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1296859919 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-16 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1296130713 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-13 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1292753402 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas