[GitHub] [solr] janhoy commented on a diff in pull request #1930: SOLR-16982: Trip a Circuit Breaker only for external requests

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1930: URL: https://github.com/apache/solr/pull/1930#discussion_r1333975664 ## solr/CHANGES.txt: ## @@ -109,6 +109,8 @@ Improvements * SOLR-15474: Make Circuit breakers individually pluggable (Atri Sharma, Christine Poerschke, janhoy) +* SOLR

[GitHub] [solr] janhoy commented on a diff in pull request #1930: SOLR-16982: Trip a Circuit Breaker only for external requests

2023-09-19 Thread via GitHub
janhoy commented on code in PR #1930: URL: https://github.com/apache/solr/pull/1930#discussion_r1329781429 ## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ## @@ -343,4 +343,16 @@ public Collection getApis() { return Collections.singleton( new

[GitHub] [solr] janhoy commented on a diff in pull request #1930: SOLR-16982: Trip a Circuit Breaker only for external requests

2023-09-18 Thread via GitHub
janhoy commented on code in PR #1930: URL: https://github.com/apache/solr/pull/1930#discussion_r1329355144 ## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ## @@ -343,4 +343,16 @@ public Collection getApis() { return Collections.singleton( new