[GitHub] [solr] janhoy commented on pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-09-05 Thread via GitHub
janhoy commented on PR #1791: URL: https://github.com/apache/solr/pull/1791#issuecomment-1706104598 @laminelam Not much left on this now, do you need help with anything? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] janhoy commented on pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-09-03 Thread via GitHub
janhoy commented on PR #1791: URL: https://github.com/apache/solr/pull/1791#issuecomment-1704350022 Backend PR merged, meaning we are unblocked to finalize this too. I'm going to mark the JIRA as blocker for 9.4 since the ref guide already promises the functionality. -- This is an automa

[GitHub] [solr] janhoy commented on pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-22 Thread via GitHub
janhoy commented on PR #1791: URL: https://github.com/apache/solr/pull/1791#issuecomment-1688203926 I tested in a real KeyCloak idp environment today, with my [custom image](https://hub.docker.com/layers/cominvent/solr/10-codeflow-csp2/images/sha256-a85f101563a03b8dc43e648d800615909570cbaa5c

[GitHub] [solr] janhoy commented on pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-24 Thread via GitHub
janhoy commented on PR #1791: URL: https://github.com/apache/solr/pull/1791#issuecomment-1648720273 I’m on vacation so please proceed without my review. I’m thrilled to see this be completed. Ok to support impl flow for 9.x but it should be removed for 10.0 -- This is an automated messag