[GitHub] [solr] janhoy commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-08-30 Thread via GitHub
janhoy commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-1699144140 So any suggestions on completing this? The pragmatic side of me says merge a working bugfix, even if not optimal. The more thorugh side says dive deep to investigate whether Jett

[GitHub] [solr] janhoy commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-08-17 Thread via GitHub
janhoy commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-1682208053 > I could totally imagine that when we were putting the list of apis that need migration together, that this one was missed! @epugh Well, this managed resource API is the only legacy V1

[GitHub] [solr] janhoy commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-08-16 Thread via GitHub
janhoy commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-1680370856 I believe there is no documentation needed since this is a bug fix? @gerlowskija any comments before I merge? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [solr] janhoy commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-08-09 Thread via GitHub
janhoy commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-167041 > > Also feel free to add a line to CHANGES.txt, giving yourself credit > > Is it ok if I added this ticket under bug section? Yes I believe that is appropriate -- This is an a

[GitHub] [solr] janhoy commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-08-08 Thread via GitHub
janhoy commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-1669386035 @gerlowskija, @risdenk added you as reviewers since you may know RestManager for context.. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr] janhoy commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-08-08 Thread via GitHub
janhoy commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-1669363880 Also feel free to add a line to CHANGES.txt, giving yourself credit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th