[GitHub] [solr] justinrsweeney commented on pull request #1267: SOLR-16608: Ability to compress the collection state

2023-02-02 Thread via GitHub
justinrsweeney commented on PR #1267: URL: https://github.com/apache/solr/pull/1267#issuecomment-1414100599 The change to the ZkCLI has some complexity that requires its own discussion, enough so that I believe it warrants its own PR once this one is merged. Since this change does not intro

[GitHub] [solr] justinrsweeney commented on pull request #1267: SOLR-16608: Ability to compress the collection state

2023-01-30 Thread via GitHub
justinrsweeney commented on PR #1267: URL: https://github.com/apache/solr/pull/1267#issuecomment-1409279200 > > > @HoustonPutman what if you could edit zk through the solr admin? Then presumably the api that pushed that data up and down could deal with the compression? I've done the same ZK

[GitHub] [solr] justinrsweeney commented on pull request #1267: SOLR-16608: Ability to compress the collection state

2023-01-30 Thread via GitHub
justinrsweeney commented on PR #1267: URL: https://github.com/apache/solr/pull/1267#issuecomment-1409278508 > Other than size units ambiguity, +1 for me! I made the update here to use minStateByteLenForCompression in all places. -- This is an automated message from the Apache Git Se

[GitHub] [solr] justinrsweeney commented on pull request #1267: SOLR-16608: Ability to compress the collection state

2023-01-06 Thread GitBox
justinrsweeney commented on PR #1267: URL: https://github.com/apache/solr/pull/1267#issuecomment-1373888188 > This would be a pretty scary feature to use for me (since there are times where modifying cluster state manually can be unfortunately necessary). > > But overall I have a few